regression: `onBeforeLoad` handler not called when overwriting `visit`

Current behavior:

onBeforeLoad hook is only getting called when defined inline with cy.visit(url, { onBeforeLoad }).

Desired behavior:

onBeforeLoad hook should get called when defined with Cypress.Commands.overwrite('visit', ...)

How to reproduce:

git clone https://github.com/sokki/cypress-test-tiny
npm i
npm run cypress:run

or look at circleci build: https://circleci.com/gh/sokki/cypress-test-tiny/1

Additional Info (images, stack traces, etc)

It seems, like the Issue was fixed in a previous version: https://github.com/cypress-io/cypress/issues/640

Test is visiting a static site (https://github.com/sokki/cypress-test-tiny/tree/master/static), deployed at https://static-fiwmrcysbv.now.sh The site just writes window.mocked || 'nope' to the body

• Operating System: macOS 10.13.3 and Linux @ circleci
• Cypress Version: 2.0.2
• Browser Version: Chrome and Electron

[jennifer-shehane]

This appears to be fixed. Tested in Cypress 3.4.0 and it passes. Closing as resolved.

[sokki]

@adamdicarlo you can find the test-repo here: https://github.com/sokki/cypress-test-tiny

Cypress.Commands.overwrite('visit', (originalFn, url, options) => {
  return originalFn(url, {
    onBeforeLoad (win) {
      win.mocked = 'mocked'
    }
  })
})