Type 'Promise<any>' is not assignable to type 'CanReturnChainable' in Cypress

Current behavior:

Having updated from Cypress 4.8, TypeScript will now not compile my support code. #435 was not insightful.

Desired behavior:

Compile my TypeScript. Either I’m doing something wrong or there is a bug.

Test code to reproduce

Cypress.Commands.overwrite(command, (originalFn, ...args) => {
  const origVal = originalFn(...args);
  return new Promise(resolve => {
    setTimeout(() => resolve(origVal), 1000);
  });
});

It fails similarly with Cypress.Promise as well. I’d like to avoid cy.wrap() unless necessary.

Versions

Cypress 4.9.0 macOS 10.15.5 Chrome 83

[0x80]

@jennifer-shehane I’m seeing similar behavior.

• Yes, it’s code added to support/index.ts
• It’s the compiler that complains. Weirdly enough the tests still run.
• No preprocessor in plugins
• Tsconfig file below

Cypress.Commands.add(
  "createReview",
  (payload: Partial<CreateReviewPayload>) => {
    const review = cleanObject<CreateReviewPayload>({
      title: payload.title || `[cy-test]`,
      description: "This is a review created for test purposes",
      tagIds: [],
      industryId: "__no_industry",
      type: "self-review",
      accountId: testAccountId,
      ...payload,
    });

    return functions
      .httpsCallable("createReview")(review)
      .then((result) => {
        const reviewId = result.data.reviewId as string;
        return firestore
          .collection("reviews")
          .doc(reviewId)
          .get()
          .then((snap) => ({
            id: reviewId,
            data: snap.data() as Review,
          }));
      });
  },
);

Error:

Argument of type '(payload: Partial<CreateReviewPayload>) => Promise<{ id: string; data: Review; }>' is not assignable to parameter of type '(...args: any[]) => CanReturnChainable'.
  Type 'Promise<{ id: string; data: Review; }>' is not assignable to type 'CanReturnChainable'.
    Type 'Promise<{ id: string; data: Review; }>' is missing the following properties from type 'Chainable<any>': and, as, blur, check, and 89 more.ts(2345)

{
  "compilerOptions": {
    "esModuleInterop": true,
    "jsx": "preserve",
    "lib": ["dom", "esnext"],
    "types": ["cypress", "node"],
    "module": "esnext",
    "moduleResolution": "node",
    "noEmit": true,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "preserveConstEnums": true,
    "removeComments": false,
    "skipLibCheck": true,
    "checkJs": false,
    "sourceMap": true,
    "strict": true,
    "target": "es2018",
    "allowJs": false,
    "forceConsistentCasingInFileNames": true,
    "resolveJsonModule": true,
    "baseUrl": ".",
    "paths": {
      "/*": ["./src/*"]
    }
  }
}

For me this issue also started when upgrading from 4.8 to 4.9

[cypress-bot[bot]]

The code for this is done in cypress-io/cypress#8501, but has yet to be released. We’ll update this issue and reference the changelog when it’s released.