target option is broken

target option is broken: https://github.com/cyrus-and/chrome-remote-interface#cdpoptions-callback

const port = 52999;
const target = await CDP.New({ port });
console.log('target:', target);
/*
target: { description: '',
  devtoolsFrontendUrl: '/devtools/inspector.html?ws=localhost:52999/devtools/page/5a5fabc4-1c6c-40c1-9181-81c56ac31707',
  id: '5a5fabc4-1c6c-40c1-9181-81c56ac31707',
  title: '',
  type: 'page',
  url: 'about:blank',
  webSocketDebuggerUrl: 'ws://localhost:52999/devtools/page/5a5fabc4-1c6c-40c1-9181-81c56ac31707' }
*/
const client = await CDP({ target });

Produces the error:

{ Error: connect ECONNREFUSED 127.0.0.1:9222
    at Object._errnoException (util.js:1019:11)
    at _exceptionWithHostPort (util.js:1041:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1175:14)
  code: 'ECONNREFUSED',
  errno: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 9222 }

It seems the default port has precedence: https://github.com/cyrus-and/chrome-remote-interface/blob/master/lib/devtools.js#L103-L104

Component	Version
Operating system	macOS / Ubuntu 16.04 / Docker
Node.js	v8.6.0
Chrome/Chromium/…	Chrome 61.0.3163.100
chrome-remote-interface	0.25.1

Is Chrome running in a container? I’ve tried both options.

[cyrus-and]

Wow, I apologize, I had a running background Chrome instance on port 9222… 😕

I’m going to fix this, in the meanwhile just pass the port in addition to the target, like this:

const client = await CDP({ target , port: chrome.port });

[cyrus-and]

Bumped: v0.25.2.