Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

tp_print renamed to tp_vectorcall_offset in cython master

See original GitHub issue

This was changed in:

https://github.com/python/cpython/pull/13185 / https://github.com/python/cpython/commit/aacc77fbd77640a8f03638216fa09372cc21673d to support https://www.python.org/dev/peps/pep-0590/

A brute-force tp_print -> tp_vectorcall_offset find-and-replace fixes it on cpython master, but is very not back-compatible 😈 . Will look into seeing if I can sort out how to gate this correctly.

Issue Analytics

State:
Created 4 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

vstinnercommented, Jun 13, 2019

@vstinner a few times a week I build cpython + the pydata stack from all of the master branches (and test at least Matplotlib). When I find issues with down-stream projects should I also report them upstream to cpython?

In case of doubt, it’s better to report the issue and asks if it’s a deliberate backward incompatible or a regression.

1reaction

scodercommented, May 31, 2019

I would be happy about a PR that

replaces the direct setting of tp_print with a C macro __Pyx_SET_TP_PRINT()
renames tp_print in the extension type struct comments with the new name, since the old name is a legacy Py2 name anyway.