Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add viewbox attribute

See original GitHub issue

Please add viewbox attribute to the SVG element, and allow to pass it as an optional @Input. Without viewbox SVGs don’t scale along with their parent container, but remain fixed to their defines width/height.

Issue Analytics

State:
Created 4 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

AsafAgranatcommented, Sep 23, 2019

My use case was, that i used an SVG directly from a Wikimedia URL, and that SVG rendered without a viewbox attribute. Not having an intermediary method to include the viewbox, i had to resolve to either download the file first, or apply an attribute on runtime, both of which solution defeat the purpose of having a convenient library to do it, in my opinion.

0reactions

czeckdcommented, Mar 6, 2020

@AsafAgranat, @bladeski angular-svg-icon@9.1.0 now has a means to set the viewBox. Here’s the documentation from the readme:

[viewBox] - An optional string to set the viewBox on the SVG. If the viewBox=“auto”, then svg-icon will attempt to convert the SVG’s width and height attributes to a viewBox=“0 0 w h”. Both explicitly setting the viewBox or auto setting the viewBox will remove the SVG’s width and height attributes.