d3 global now missing in electron

First of all, thank you for this awesome library! I’ve learn lots of stuff under its hood and I was able to write a disk space visualization app fairly thanks to d3.

However, in the last npm updates, the d3 global is no longer defined in Electron. I currently include d3 in electron like

<script src="node_modules/d3/d3.js"></script>

I believe the change was caused by commit 1fad2e0cf7fba217eba0eadf3cae17c15090f1dd. Of course this could be Electron specific (it having both browser and node properties), and one workaround for me is to write

<script> var d3 = require('d3') </script>

Just checking if the current d3 behaviour is correct and whether you think my solution is sound.

[albertosantini]

At last, for my use case, I added "node-integration": false to BrowserWindow options, as suggested in https://github.com/electron/electron/issues/254

Now <script src="node_modules/d3/d3.js"></script> works nice in the usual browser env and electron one.

[albertosantini]

My use case is a bit different.

I have an express app: it works like a web app and an electron one.

When I start the app in electron environment, the global d3 object is not available. That is due to typeof module === "object" && module.exports is true.

main.js

...
require("./src/server/app"); // start the express app
...
mainWindow.loadUrl("http://localhost:8000");

index.html

...
<script src="https://cdn.rawgit.com/mbostock/d3/master/d3.min.js"></script>
...

As workaround I need to add the following line to the index.html

...
<script src="https://cdn.rawgit.com/mbostock/d3/master/d3.min.js"></script>
<script>if (typeof module === "object") { window.d3 = module.exports; }</script>

I suggest to add also this.d3 = d3 if window is defined in module part:

  if (typeof define === "function" && define.amd) 
      this.d3 = d3, define(d3); 
  else if (typeof module === "object" && module.exports) 
      module.exports = d3; 
      if (typeof window === "object") // new line
          this.d3 = d3; // new line
  else 
      this.d3 = d3;

or changing the condition for module case to enter in the last else part:

  else if (typeof module === "object" && module.exports && typeof window === "undefined") 

Does it make sense?