Asset Job - unable to launch backfill when there is required asset/resource config
See original GitHub issueDagster version
1.1.1
What’s the issue?
When attempting to launch a backfill for an asset job that has asset/resource config that is marked as required, the materialize all
button opens the launchpad
UI instead of the launch backfill
UI
What did you expect to happen?
We expect this button to open the launch backfill
UI instead of the launchpad
UI.
Since 1.1.1, the Asset Job partition page’s launch backfill
button has been replaced with a materialize all
button which uses logic for launching runs for assets
https://github.com/dagster-io/dagster/blob/release-1.1.2/js_modules/dagit/packages/core/src/partitions/AssetJobPartitionsView.tsx#L84
This logic contains two checks anyAssetsHaveRequiredConfig
and anyResourcesHaveRequiredConfig
which shows the launchpad UI if there is required asset/resource config, or shows the partition UI if there is no required asset/resource config.
https://github.com/dagster-io/dagster/blob/release-1.1.2/js_modules/dagit/packages/core/src/assets/LaunchAssetExecutionButton.tsx#L351
This check made sense previously when this button was only used for Assets, because asset/resource config could not be provided by other means, however doesn’t make sense for asset jobs, which could have asset/resource config that is required, which is filled in via partitioned config.
How to reproduce?
- create an asset that has
resource_defs
with a config field that is marked asrequired
, or aconfig_schema
with a field marked as required. - use this asset to create an asset job using
define_asset_job
- launch the UI, go to the job, and then to the partitions tab
- press the
materialize all
button, and instead of thelaunch backfill
UI, thelaunchpad
UI is shown
Deployment type
Local
Deployment details
No response
Additional information
No response
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
Issue Analytics
- State:
- Created 10 months ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
Hey folks! The fix for this merged in https://github.com/dagster-io/dagster/pull/10905. When a user-defined asset job has partitions, we always assume that the config will be provided (via job-level
PartitionedConfig
) and a backfill is possible (essentially the same as the old pre-1.1.0 behavior).This changes the button to show the partition range picker – if you want to customize config and launch a single partition, you can hold shift when clicking Materialize.
Thanks for your patience @xWaita!
Got it - that makes sense @xWaita .
@bengotow is working on this, and a fix will be included in Thursday’s release.