Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
K8sContainerContext is missing tolerations, nodeSelector, and podSecurityContext
See original GitHub issueDagster version
1.0.11
What’s the issue?
When a run job/pod is created, it doesn’t include all the config of the user repo deployment, even if includeConfigInLaunchedRuns.enabled is true. It is missing tolerations, nodeSelector, and podSecurityContext.
What did you expect to happen?
I expected all the config specified in the elements of the deployments list to be copied to the run jobs/pods, if includeconfigInLaunchedRuns.enabled is true.
We’d need to add those missing properties here: https://github.com/dagster-io/dagster/blob/f5ea4b7d861d4966166b54bc575b7a3ebbfe7851/python_modules/libraries/dagster-k8s/dagster_k8s/container_context.py#L24
How to reproduce?
No response
Deployment type
Dagster Helm chart
Deployment details
No response
Additional information
No response
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Probably, I think, isn’t enough. If you decided to dig into it - I think you need add a container security contexts accordingly to docs: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#securitycontext-v1-core There is some options who available only on container security context level, e.g. allowPrivilegeEscalation
Hi @craustin, yeah those should be added. Feel free to pr, otherwise we can take it