question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

cappingMinimumTimeInterval seems to be not working for me

See original GitHub issue

Hey, I’m creating an instance of VASTClient with a cappingMinimumTimeInterval following the documentation, just like this:

const vastClient = new VASTClient(0, 900000);

but it seems to ignore the interval, and I get consecutive requests. And I run is just like this:

playtBtn.addEventListener("click", () => {
  mainPlayer.addEventListener("play", requestAds);
});

function requestAds() {
  vastClient
    .get(dviadlink)
    .then((res) => {...

After running an ad (successful request) I hit the play button and get another request. Am I doing something wrong, I’m not sure? For now the property just seems to be ignored somehow.

The library version is 2.5.1. #

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:9 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
Niyatsucommented, Jul 1, 2020

@ZacharieTFR That’s true, I checked the mock link you provided and it worked for me as well in my app. Funny thing is, I checked the original link (https://ads2.adviad.com/www/delivery/fc.php?script=apVideo:vast2&offset=true&mp4=1&zoneid=787) in a couple of VAST testers (like this one: http://tools.springserve.com/tagtest) and it works there. That’s what confused be in the first place. But I guess I’ll try to update vast-client now and then try to communicate with provider.

1reaction
ZacharieTFRcommented, Jun 17, 2020

Hello @Niyatsu,

Thanks for creating the issue, indeed I can reproduce it. I will create a PR to fix it 👍

Just to let you know the most recent version is the pre-release 3.0.0-alpha.10, it’s stable and we will release officially the 3.0-version soon.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Free Automated Malware Analysis Service - powered by Falcon ...
Submit malware for free analysis with Falcon Sandbox and Hybrid Analysis technology. Hybrid Analysis develops and licenses analysis tools to fight malware.
Read more >
October 28, 2016 - gists · GitHub
<li><em class="me">Mat Kelly</em>, Michael L. Nelson, and Michele C. Weigle, "Visualizing Digital ... <li>PHI2630 - Contemporary Moral Issues</li>.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found