question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Removing dropdownSelector configuration option (Breaking change)

See original GitHub issue

In an effort to make the code simpler and reduce dependencies & tight coupling, I’m considering dropping support for the dropdownSelector configuration option.

This option only works with jQuery and Bootstrap Javascript, and the developer can implement on their own method for closing a dropdown in the on-set-time callback.

$scope.onTimeSet = function (newDate, oldDate) {
    // do something with new/old date as needed

   // close the dropdown with jQuery
  $('#dropdown1').dropdown('toggle');
}

Please comment on this issue if there are any reasons why this won’t work for you.

Issue Analytics

  • State:closed
  • Created 8 years ago
  • Comments:11 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
jice-lavocatcommented, Mar 26, 2017

@dalelotts you could add this to the documentation. I think it’s easier if your library does not handle the dropdown itself.

0reactions
dalelottscommented, Feb 1, 2018

This will not be removed from 1.x, however it will not be included in 2.x

Read more comments on GitHub >

github_iconTop Results From Across the Web

Create config window · Issue #5 · crc-org/tray-windows - GitHub
Do we need warn for the user? They mostly exist for debug and solving a breaking change. ... Yes skip should be enough,...
Read more >
Is replacing an optional parameter with overloads a breaking ...
Maybe if the client has to be recompiled (which I would assume for removing overloads), this could be considered a breaking change. ·...
Read more >
What should I call content that drops down, without calling it a ...
Writing up the notes, I want to refer to the dropdown selector and at the same time to the group of configuration options...
Read more >
Types of breaking changes - .NET - Microsoft Learn
NET versions, and what kind of change is considered a breaking change. ... ALLOWED: Removing an interface implementation from a type when ...
Read more >
Creating and Synchronizing Live Copies - Experience League
You can edit or delete an existing blueprint configuration: ... If you do not select this option, a copy of the blueprint is...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found