Ambient declarations not working due to import/export

The import and export statements in danger.d.ts are preventing the danger DSL from being available in the global scope:

This is a known issue in Typescript *.d.ts files (ambient declarations): https://github.com/microsoft/TypeScript/issues/28097

A potential solution per this comment is to wrap global declarations in a declare global { } block.

EDIT: This appears to do the trick based on a quick test. Here’s a minimum set of changes: https://github.com/carmanchris31/danger-ambient-declarations-repro/commit/e897e351bb253505075606acc9fde51fc429776e?w=1

Where should one look in the code in order to attempt addressing this?

[fbartho]

We could provide a file that plugin authors could directly reference that would hook up that global scope?

Danger-plugin-interface.d.ts (not sure if that would work?)

[airtonix]

You should never need to include those helpers in user-land Dangerfile

That said, I think re-exporting the types from an index file is a cool idea 👍🏻

wat?

without import { DangerDSLType} from 'danger';

with import { DangerDSLType} from 'danger';

it’s really strange that you’re injecting stuff into global space in the first place to be brutually honest.