Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`danger local --base` inconsistency

See original GitHub issue

Doing some more testing with --base, looks like it is being ignored on the call tolocalGetDiff triggered in the subprocess:

DEBUG="*" ./node_modules/.bin/danger local --base develop
 danger:process_runner Starting sub-process run with  +0ms
 danger:localGetDiff git diff develop...HEAD +0ms
 danger:localGetDiff git log develop...HEAD --pretty=format:'{ "sha": "%H", "parents": "%p", "author": {"name": "%an", "email": "%ae", "date": "%ai" }, "committer": {"name": "%cn", "email": "%ce", "date": "%ci" }, "message": "+0ms"},'
 danger:process_runner Preparing to run: /Users/adam.moss/.nvm/versions/node/v9.4.0/bin/node,/Users/adam.moss/projects/project_name/node_modules/danger/distribution/commands/danger-runner.js,--base,develop +29ms
 danger:runDangerSubprocess Running subprocess: node - /Users/adam.moss/projects/project_name/node_modules/danger/distribution/commands/danger-runner.js,--base,develop +0ms
2018-01-24T14:00:53.419Z danger:runner Started Danger runner with

2018-01-24T14:00:53.426Z danger:runner Got STDIN for Danger Run

2018-01-24T14:00:53.441Z danger:localGetDiff git diff master...HEAD

2018-01-24T14:00:53.455Z danger:localGetDiff git log master...HEAD --pretty=format:'{ "sha": "%H", "parents": "%p", "author": {"name": "%an", "email": "%ae", "date": "%ai" }, "committer": {"name": "%cn", "email": "%ce", "date": "%ci" }, "message": "%s"},'

2018-01-24T14:00:53.469Z danger:runner Evaluating dangerfile.js

2018-01-24T14:00:53.470Z danger:inline_runner Started parsing Dangerfile:  dangerfile.js

2018-01-24T14:00:53.470Z danger:inline_runner Finished running dangerfile:  dangerfile.js

2018-01-24T14:00:53.471Z danger:inline_runner Scheduler waiting on: 0 tasks

2018-01-24T14:00:53.471Z danger:inline_runner Finished scheduled tasks

2018-01-24T14:00:54.424Z danger:runner Process has finished with 0 undefined, sending the results back to the host process

 danger:runDangerSubprocess Got JSON results from STDOUT +1s
 danger:runDangerSubprocess child process exited with code 0 +5ms
 danger:executor Got Results back, current settings { stdoutOnly: true,
 verbose: undefined,
 jsonOnly: false,
 dangerID: 'default' } +0ms
 danger:executor Writing to STDOUT: { fails: [],
 warnings: [],
 messages: [],
 markdowns: [],
 scheduled: [] } +2ms
Danger: Passed review, received no feedback.

Issue Analytics

State:
Created 6 years ago
Comments:12 (6 by maintainers)

Top GitHub Comments

1reaction

peterjgraingercommented, Jan 24, 2018

Issue is here where base is hardcoded to master

https://github.com/danger/danger-js/blob/f7a528779623f8e2be74cc4f100c744f0ef2696f/source/runner/jsonToDSL.ts#L18

Will try and find where to change

0reactions

ortacommented, Jan 29, 2018

Thanks, I made that extension 😉

Top Results From Across the Web

Understanding EtherChannel Inconsistency Detection - Cisco

This presents a danger of the creation of forwarding loops if channeling ports are not consistent on both sides of the channel. This...

The environment is inconsistent, please check the package ...

I use the base/root environment just to keep conda fresh. Unfortunately, I don't have the exact message and the list of inconsistent ......

Local git repository is inconsistent with github repo

I use git for my source management, I have a local repository on my mac and a remote repository at github. They are...

Prescription Errors and Outcomes Related to Inconsistent ...

Background. Although several types of computerized provider order entry (CPOE)-related errors may occur, errors related to inconsistent information within ...

Fix local tiller default enabled inconsistency (!37494) · Merge ...

Fixes an inconsistency missed in !35562 (merged) where we set the feature ... Danger has picked a candidate for each review slot, based...