question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Investigate Danger for synchronous methods

See original GitHub issue

When running Danger inside Peril, it’s very likely that any blocking call is going to cause pretty serious issues over the long run. So Danger will need any xxSync functions converted to the xx version.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
ortacommented, Jun 9, 2017

Ah yeah, afraid so - the artsy site was taking some serious downtime due to one sync call in all our node app, took a long time to find it - wanted to try get that sorted before it became an issue

0reactions
ortacommented, Jun 10, 2017

I feel like source/ci_source/get_ci_source.ts and source/runner/DangerfileRunner.ts will be the only ones we’ll care about in those cases 👍

thanks

Read more comments on GitHub >

github_iconTop Results From Across the Web

Should I expose synchronous wrappers for asynchronous ...
To understand why, let's examine what it looks like to wrap an asynchronous method with a synchronous one.
Read more >
5 Major Problems With Synchronous Code Reviews
5 major problems with synchronous code reviews · Direct dependencies · Forces context-switching · Not done consistently · Time pressure · Lack of...
Read more >
What are synchronous/asynchronous APIs? - TechTarget
An API is usually synchronous when data or service availability, resources and connectivity are high and low latency is a requirement.
Read more >
Impact of Synchronous and Asynchronous Settings of Online ...
The present study investigates how synchronous and asynchronous settings of teaching and learning during the 2020 lockdown affected student ...
Read more >
Investigation Concerning the Excitation Loss of Synchronous ...
An LOE in one generator causes a dangerous increase in armature currents in both generators. The results of this study prove that the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found