Semaphore - Might need disclaimer
See original GitHub issueNot sure where the docs for this page are located, otherwise I would have just done a PR: http://danger.systems/js/guides/getting_started.html
The semaphore integration works, but there’s a catch. Semaphore won’t do a PR build unless it’s a fork. So anyone who owns the repo, and simply does branch PRs, will see this message:
I wrote to Semaphore and they responded with the following:
After a project has been added, Semaphore builds branches that are created within the repository.
Because of this, at the moment Semaphore doesn't support building pull requests that are opened
within the same repository. Opening a PR will trigger a build only if it was opened from a fork. For
more details please refer to this page.
Good news is that adding the option for building pull requests within repository is on our roadmap.
So, we'd really appreciate if you have few moments to describe your use-case. We don't have an
ETA yet, but we expect to deliver this feature during the first half of 2018.
I believe a caveat should be added to the docs (I personally moved danger-js to Travis for this reason). But then again, maybe danger JS should detect semaphore and be willing to skip the detection process?
I hope this helps ^
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:5 (3 by maintainers)
Top Results From Across the Web
sem_wait()-Wait for Semaphore - IBM
The sem_wait() function decrements by one the value of the semaphore. The semaphore will be decremented when its value is greater than zero....
Read more >Terms of Service - Semaphore CI
Semaphore will not intentionally disclose, distribute, transmit or use any Customer Data except (a) as reasonably necessary for Semaphore (or ...
Read more >Semaphores and Semaphore Timeouts - HCL support
If a user task now tries to open that index while it is being rebuilt, it will have to wait for the indexer...
Read more >Semaphore (programming) - Wikipedia
In computer science, a semaphore is a variable or abstract data type used to control access ... Some other mechanism (possibly involving more...
Read more >Semaphores don't have owners - The Old New Thing
(This increase might release waiting threads.) But the thread releasing the semaphore need not be the same one that claimed it originally.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Have any updated ? I also have this problem. Do you have workaround for this one ?
Here’s your workaround https://semaphoreci.com/docs/how-to-fetch-pull-request-number-from-github.html
Edit: These docs are outdated, but it does work with changes