onNodePositionChange is not called every time
See original GitHub issueDescribe the bug I’ve seen this problem discussed here: https://github.com/danielcaldas/react-d3-graph/issues/264 and it seems like the bug was closed, but I’m still experiencing the same issue.
To Reproduce I cannot pinpoint what the problem is. It just seems to randomly work/not work regardless of what I’m doing. Sometimes it doesn’t trigger even when I move a node halfway across the screen, but then it does trigger if I move it again just a tiny bit.
Expected behavior
The onNodePositionChange
callback should be triggered every time a node is moved.
Screenshots
The console.log statement is triggered every time a node is moved. In my case, I moved the Employee Lounge - more dialogue
node two times, but the console.log statement was triggered only once.
Environment:
- OS: Ubuntu 18.04
- Browser Chrome
- Version 80
- Node version 10.12.0
- react-d3-graph version 2.4.0
- d3 version 5.15.0
- react version 16.8.6
Additional context Add any other context about the problem here.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:10 (6 by maintainers)
Top GitHub Comments
Yup, everything works correctly now! The links follow the custom
type
property and I’ve tested theonNodePositionChange
callback for a few minutes and it was called every time. Thank you for the release! 😃 I will close this ticket and the other one.Indeed
lib
seems not to be up to date 🤔 I’m working on releasing a patch version2.4.1
that hopefully should fix this. Thanks for catching this one @NoMercy235 🙏