Missing dependency "Moment" on new and upgraded projects, while using OwlNativeDateTimeModule

Even whilst not using Moment.js, there still appears to be a dependency for this date-time-picker. When you try to npm start a new or upgraded project, you will be hit with:

Error: The target entry-point "@danielmoncada/angular-datetime-picker" has missing dependencies:
 - moment

I was able to reproduce the error by creating a new angular app (with Angular Material) and setting up the imports:

@NgModule({
     imports: [ 
         OwlDateTimeModule, 
         OwlNativeDateTimeModule,
     ],

In projects where we used this date-time-picker, we have always used OwlNativeDateTimeModule and never the OwlMomentDateTimeModule, as stated in the documentation. I got the error after upgrading to Cypress 7, so it appears Cypress 6 was our last package that installed moment as a dependency.

As you might know already know, Moment.js is a legacy project. Reason enough to move away from it in new and upgraded projects, as apparently more projects are doing.

[florisvanderhaar]

Yes, installing Moment.js is a valid workaround for the immediate short term.

However, in doing so I will add a package to my application that’s not in active development anymore, while I purposely configured the date-time-picker to use the OwlNativeDateTimeModule instead of Moment. This is a bad practice.

IMHO: The aim should always be to install the least amount of dependencies on a new project and avoid leaving any unwanted, unused or deprecated packages in a project during an upgrade.

Moment.js hadn’t been deprecated yet when the date-time-picker was made. But still the documentation wrongly states:

There are two pre-made modules:

OwlNativeDateTimeModule – support for native JavaScript Date object OwlMomentDateTimeModule – support for MomentJS object. (need to npm install ng-pick-datetime-moment and moment packages)

Source: https://danielykpan.github.io/date-time-picker/#locale-formats

TLDR; I shouldn’t have to install a package I’m not using.

[danielmoncada]

Okay… finally had time to remove the MomentAdapter, and extract it out into a separate project.

This is in the latest version (https://github.com/danielmoncada/date-time-picker/pull/143) v13.1.0.

If anyone does need a MomentJs adapter, you can find it here npm or GitHub.