Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Info verbosity level is too verbose

See original GitHub issue

Info output:

  2020-03-04T10:40:18: Executable: C:\Users\vihofer\.nuget\packages\dotnet-reportgenerator-globaltool\4.5.0\tools\netcoreapp3.0\any\ReportGenerator.Core.dll
  2020-03-04T10:40:18: Working directory: C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug
  2020-03-04T10:40:18: Loading report 'C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\coverage.xml' 1/1 in memory
  2020-03-04T10:40:19: Starting merging result 1
  2020-03-04T10:40:19: Finished merging result 1
  2020-03-04T10:40:19: Finished parsing 'C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\coverage.xml' 1/1
  2020-03-04T10:40:19: Parsing of 1 files completed
  2020-03-04T10:40:19: Initializing report builders for report types: Html
  2020-03-04T10:40:19: Analyzing 38 classes
  2020-03-04T10:40:19:   Writing report file 'C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\report\index.htm'
  2020-03-04T10:40:19: Report generation took 0.9 seconds

I believe these outputs should only be included in the verbose level:

  2020-03-04T10:40:18: Executable: C:\Users\vihofer\.nuget\packages\dotnet-reportgenerator-globaltool\4.5.0\tools\netcoreapp3.0\any\ReportGenerator.Core.dll
  2020-03-04T10:40:18: Working directory: C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug
  2020-03-04T10:40:18: Loading report 'C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\coverage.xml' 1/1 in memory
  2020-03-04T10:40:19: Starting merging result 1
  2020-03-04T10:40:19: Finished merging result 1
  2020-03-04T10:40:19: Finished parsing 'C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\coverage.xml' 1/1
  2020-03-04T10:40:19: Parsing of 1 files completed
  2020-03-04T10:40:19: Initializing report builders for report types: Html
  2020-03-04T10:40:19: Analyzing 38 classes

Also notice the extra indentation here: 2020-03-04T10:40:19: Writing report file 'C:\git\runtime4\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\report\index.htm'.

Issue Analytics

State:
Created 4 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

ViktorHofercommented, Apr 17, 2020

Daniel, quick question on this. With 4.5.2 I see the following output:

  2020-04-17T16:47:36: Executable: C:\Users\vihofer\.nuget\packages\dotnet-reportgenerator-globaltool\4.5.2\tools\netcoreapp3.0\any\ReportGenerator.Core.dll
  2020-04-17T16:47:36: Working directory: C:\git\runtime3\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug
  2020-04-17T16:47:37: Writing report file 'C:\git\runtime3\artifacts\bin\System.Text.RegularExpressions.Tests\netcoreapp5.0-Debug\report\index.htm'
  2020-04-17T16:47:37: Report generation took 1.0 seconds

I believe the Executable and Working directory log lines should be removed from the Info verbosity level as well.

The path to the executable shouldn’t be relevant for (global-)tool consumers.
The working directory presumably is the cwd most of the time. Do we really need it be logged as well?

The path to the report definitely makes sense to be printed.

Thanks for all the great you are doing with ReportGenerator 👍 👍 👍

0reactions

ViktorHofercommented, Apr 18, 2020

Thanks a lot 😃