Loading lazy associations via Related Resource Links causes association to be dirty

I’ve managed to isolate the issue I was seeing when I commented on #28.

When an association is loaded via a related resource link and there is no data linkage for this association (i.e. missing the ‘id’ and ‘type’) then the association is considered to be changed, thus dirtying the model.

JSON API example e.g.

{
  "data": {
    "type": "project",
    "attributes": {
      "title": "Project1"
    },
    "id": 1,
    "relationships": {
      "company": {
        "links": {
          "related": "/projects/1/company"
        }
      }
    }
  }
}

I’ve written a breaking test for belongsTo and hasMany associations to demonstrate the problem. I’ll push it to a branch shortly

[danielspaniel]

Sure thing @richardfrosztega , best thing is to clone this repo, and make a PR for your branch in your repo against mine. Thanks for working on it. I appreciate it and others will too.

[richardfrosztega]

I’ve been working on a fix based on this from inside ember data Relationship

/*
       This flag indicates whether we should
        re-fetch the relationship the next time
        it is accessed.
        The difference between this flag and `shouldForceReload`
        is in how we treat the presence of partially missing data:
          - for a forced reload, we will reload the link or EVERY record
          - for a stale reload, we will reload the link (if present) else only MISSING records
        Ideally these flags could be merged, but because we don't give the
        request layer the option of deciding how to resolve the data being queried
        we are forced to differentiate for now.
        It is also possible for a relationship to remain stale after a forced reload; however,
        in this case `hasFailedLoadAttempt` ought to be `true`.
      false when
        => recordData.isNew() on initial setup
        => a previously triggered request has resolved
        => we get relationship data via push
      true when
        => !recordData.isNew() on initial setup
        => an inverse has been unloaded
        => we get a new link for the relationship
      TODO @runspired unskip the acceptance tests and fix these flags
     */
    this.relationshipIsStale = false;

I just need some time to tidy it up from POC to production ready. Once I’ve got it together would you like me to put it on a branch @danielspaniel?