Android build fails: com.google.android.gms:play-services-analytics version need to be specified

Hi,

Right now com.google.android.gms:play-services-analytics:+ doesn’t explicitly specify a version number for the library which lead to a gradle conflict while using phonegap-plugin-push 2.0.0

Would you be ok to modify following line of plugin.xml?

Instead of

 <framework src="com.google.android.gms:play-services-analytics:+" />

Specifying the use of version 11.0.1

 <framework src="com.google.android.gms:play-services-analytics:11.0.1" />

This fix the conflict error.

Related issue phonegap-plugin-push: https://github.com/phonegap/phonegap-plugin-push/issues/1718

[macdonst]

@danwilson I’m working with the cordova-cli team to add the ability to include variables in the framework tag.

So right now you have:

<framework src="com.google.android.gms:play-services-analytics:+" />

and when it is done we can specify:

<preference name="PLAY_SERVICES" default="+"/>
<framework src="com.google.android.gms:play-services-analytics:$PLAY_SERVICES" />

but then users will be able to over-ride the play services version to match other plugins that depend on the same framework but pin a specific version.

I’ll send a PR when it’s ready.

[iPzard]

@BhavikaP Glad to help 😃… Let me know how it goes!