Inconsistent signature usage of addCustomDimension
See original GitHub issueThe usage of the key
parameter of addCustomDimension
differs between the platforms, the README and the typescript definition.
In the README, the android and wp8 platform it is defined as number where it in iOS and the typescript definition it is defined as string.
See following lines:
- https://github.com/danwilson/google-analytics-plugin/blob/master/ios/UniversalAnalyticsPlugin.m#L158
- https://github.com/danwilson/google-analytics-plugin/blob/master/typescript/analytics.d.ts#L32
- https://github.com/danwilson/google-analytics-plugin/blob/master/android/UniversalAnalyticsPlugin.java#L85
- https://github.com/danwilson/google-analytics-plugin/blob/master/wp8/UniversalAnalytics.cs#L200
I think the right type for this parameter should be number? If you could confirm I would make sure it is consistent over all platforms.
Issue Analytics
- State:
- Created 7 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
What do I do if I can not replicate my signature exactly ...
1. Real signatures are always slightly different and they differ every time. 2. If the signatures are exact replica there is a very...
Read more >MTS TestSuite™ TW Elite User Guide
Software use and license is governed by MTS' End User License Agreement which defines all rights ... Add Custom Dimension window appears.
Read more >My signature is noticeably different every time I write it. ...
Mine is just an S followed by some inconsistent scribbles. I feel like this should have caused an issue with a bank or...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
https://github.com/danwilson/google-analytics-plugin/pull/325
no worries… I wish I had more experience with Objective C and Java, as I’d love to get the Enhanced Ecommerce working…