No option to shut down the side car
See original GitHub issueExpected Behavior
When using Dapr with Kubernetes Job it is advised by the documentation that we should call the shutdown endpoint either using the Dapr SDK or using the command option in deployment. The reference to the document is attached herewith (https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-job/). The Dapr SDK at present does not have a shutdown method. The “dispose” method does not shut down the Sidecar
Actual Behavior
We need a method to shutdown the side car
Steps to Reproduce the Problem
Run the yaml below. The job will not get completed at all. This is because there is no Shutdown method in SDK
apiVersion: batch/v1 kind: Job metadata: creationTimestamp: null name: dapr-state-job namespace: m2c-steeltoe spec: template: metadata: creationTimestamp: null annotations: dapr.io/enabled: "true" dapr.io/app-id: "dapr-state-job" dapr.io/enable-api-logging: "true" spec: containers: - image: venkateshsrini3/dapr-state-job name: dapr-state-job #command: ["sh", "-c","apt-get update && apt-get -y install curl && dotnet dapr.state.console.dll && curl -X POST localhost:3500/v1.0/shutdown"] env: - name: "State.Store" value: "mongo-cache-store" restartPolicy: Never
Release Note
Add an method called hutdown in SDK
ADDRELEASE NOTE:
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:6 (4 by maintainers)
Top GitHub Comments
@mcandeia - I took care of this one yesterday, see the PR referenced above.
@halspang could you please let me know when this upgraded nuget package will be available?