question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Changes to Dynamic Theme get reverted/deleted

See original GitHub issue

Describe the bug

When I use DR’s dev tools to modify the default Dynamic Theme, the changes get reverted.

Steps to reproduce

  • Set Firefox to delete all items (cache, etc.) on close
  • Disable syncing DR dynamic theme updates
  • Using DR dev tools (v5 preview), add CSS rulesets to the * section of the dynamic theme
  • Close Firefox
  • Reopen Firefox
  • Inspect the DR dynamic theme

Expected behavior

Changes to dynamic theme not lost

Actual behavior

All changes to dynamic theme get reverted

System Information:

  • OS: Windows
  • Browser: Firefox 83
  • Dark Reader version: Version 5 Preview (4.9.26)

Additional context

Although this looks like a bug, it could possibly be an unintended consequence of not conveying when (and why) the dynamic theme would get reverted.

The bottom line is that I would like to be able to make changes to the dynamic theme and not lose those changes. I have not submitted these changes to be applied to all Dark Reader users because they may only be applicable to specific OS themes, and possibly only specific browsers. The changes involve modifying the CSS for all input, select, and textarea HTML elements. For example:

input, select, textarea { color: var(--darkreader-selection-text) !important; }

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:31 (21 by maintainers)

github_iconTop GitHub Comments

3reactions
Gustedcommented, Nov 19, 2021

See #7359

2reactions
Gitoffthelawncommented, Dec 25, 2021

As I jokingly say to a good friend of mine, “Your issues have issues.” 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

226791 - fix dynamic theme switching feature - Bugzilla@Mozilla
We need to remove the dynamic theme switching feature and just require a restart. This means removing the "use this theme" checkbox on...
Read more >
Build Truly Dynamic Theme with CSS Variables - Medium
Big problem of this solution — Scss files not have access to color variables, leading to: Colors can't be applied to pseudo class...
Read more >
Change Dynamically Theme In Flutter | by Shaiq khan
This demo video shows how to change the dynamic theme in a flutter and shows how a dynamic theme will work using the...
Read more >
Dynamic theme change in Semantic-UI - Stack Overflow
Correct. Depending on whether you're having per-user styles, or just multiple themes the user can pick from, you can simply have separate less ......
Read more >
Getting effect on the dynamic theme changes in Xamarin.Forms
This article explains the topic, How to get the dynamic theme change effect in numeric control inside the Xamarin.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found