Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Domains and Subdomains Behave Differently on Site List

See original GitHub issue

After further reading, this appears to be a bug, and not a Broken Website. I’ve updated the issue to reflect that.

Dark Reader Version: 4.9.16

Bug Description

In the case of toggling Dark Reader on a subdomain, the entry into the list is specific, i.e., only effecting docs.gitlab.com, and not gitlab.com or any other subdomains.
In the case of toggling Dark Reader on a domain, the entry into the list is generic, i.e., it effects gitlab.com, as well as docs.gitlab.com and any other subdomain.

This behavior is inconsistent and seems more like a bug.

Potential Bugfix: Even adding a future that would allow you to manually input //gitlab.com to limit it to the domain (i.e., excluding sub-domains) would be a great way to compromise on this bug! 😄

A broader discussion on this started in this comment below.

ORIGINAL POST

Website https://docs.gitlab.com/ee/ci/quick_start/

How to Reproduce Steps to reproduce the behavior: An example of this is

Go to Gitlab Docs website

Attempt to activate Dark Reader

Expected behavior Dark Reader activates and Dark Reader generates a dark theme

Actual behavior docs.gitlab.com remains disabled

Screenshots

System info:

OS: All OS’s (screenshot is from Arch; tried on macOS and Windows as well)

Browser: Attempted with both Chrome and Firefox

Issue Analytics

State:
Created 3 years ago
Reactions:8
Comments:19 (7 by maintainers)

Top GitHub Comments

10reactions

HatScriptscommented, Oct 29, 2020

So here’s a prominent example of where I found this bug/feature to be the most frustrating:

If for whatever reason you disable stackexchange.com, then every one of the ~166 subdomains (e.g. english.stackexchange.com, math.stackexchange.com, unix.stackexchange.com) will also be disabled.

But not only disabled, also impossible to enable again the intuitive way of clicking the button:

3reactions

Gustedcommented, Nov 5, 2020

Hi @HatScripts and @BoltonBailey!

I almost forget to make a comment on this issue, but after @HatScripts comment I was turned and made a change to the existing PR(#2517) which if everything goes as plan should replace the current matching logic. The change was purely targeted to fix the subdomain problem matching more info at https://github.com/darkreader/darkreader/issues/373#issuecomment-720103647 and https://github.com/darkreader/darkreader/pull/2517#issuecomment-720103367

Regards, Gusted