Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] System color scheme does not work on Firefox

See original GitHub issue

Bug Report

Bug Description

Extension never activates dark mode when Automation is set to Use system color scheme. It works fine with the other 2 automation modes.

Steps To Reproduce

On any website (e.g. mozilla.org)
Activate “Use system color scheme”
Make sure your system’s theme is in dark mode
Observe as no dark mode is applied

Expected Behavior

The extension’s dark mode is applied

Actual Behavior

The extension’s dark mode is not applied

Screenshots

1	2	3

System Information

OS: macOS 12.5
Browser: Firefox Dev 104.0b9
Dark Reader Version: 4.9.55

Issue Analytics

State:
Created a year ago
Comments:22 (1 by maintainers)

Top GitHub Comments

2reactions

bershanskiycommented, Aug 18, 2022

I feel like I owe you the complete story:

On Aug 9, I was testing Dark Reader for an upcoming release and noticed that Chrome was not firing matchMedia events in background page. Then I tested Firefox under the same conditions and it was fine, so we released Firefox build, postponed Chrome release. (Link to developer-only chat) Then I created #9526 which activated color change listeners in all builds (including Chrome MV2 and Firefox). This approach worked well in Chrome MV3 build before, so I expected it to work fine in other builds (and it did in Chrome MV2 build). Firefox did not like it (#9540). In #9554, we added filtering for excessive messages on Chrome (as a precaution) and made Firefox ignore them entirely as a fix. We disabled these messages on Firefox because I believed Firefox backgrounds were getting color change messages reliably. (Side note: we have a workaround for a different bug on Firefox which makes initial color scheme inaccurate, but did not prevent change events from firing.)

Possible fix: I believe we can re-enable these messages again for Firefox (hopefully, without triggering #9540 because we filter out excessive messages). I would really appreciate if you could help me test the fix before release. Also, I would appreciate if you could test fix on Google Search video results specifically, as explained here.

1reaction

adqlcommented, Aug 17, 2022

Probably related and very recent: #9533

Top Results From Across the Web

Unchecking "use system colors" no longer works when high ...

One option would be to change the functionality of the "Use System Colors" option so that if it is disabled, it also ignores...

Dark mode in all firefox browsing sites do not work now

You can check whether Firefox is applying a High Contrast system theme in the Colors dialog. Either: Windows: "3-bar" menu button (or Tools...

firefox color worked then stopped - Mozilla Support

i tired making my own theme in firefox color and when i do it can't download the i file. so what i understand...

Auto Dark Mode feature on websites does not work

I am using Firefox 89.0.2 on Windows 10 21H1 and even though I have set the system theme to dark (which Firefox's System...

Firefox 92.0 does not follow the Windows system theme

Did you try to revert the color setting in Settings (Options/Preferences) ? Settings -> General: Fonts & Colors -> Colors: "Override the colors ......