question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Toggle status is ignored if query string contains square braces

See original GitHub issue

Describe the bug If you navigate to a page you have disabled DarkReader for (via the toggle) and the URI for that page contains a [ (in the query string) then the rule you have set will be ignored.
When the braces are encoded this issue does not occur.

To Reproduce Steps to reproduce the behavior:

  1. Navigate to google.co.uk
  2. Disable DarkReader via the quick toggle
  3. Notice DarkReader isn’t applied
  4. Navigate to google.co.uk?foo=[bar]
  5. Notice DarkReader is applied

Expected behavior DarkReader should not be applied when it is toggled off

Screenshots If applicable, add screenshots to help explain your problem. image image

System Information:

  • MacOS 10.15.4
  • Chrome 83.0.4103.61

Additional context Note: Between my first and second screenshot, DarkReader was not toggle manually

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
Gustedcommented, May 29, 2020

That’s right it was a temporary solution to target IPV6, but like said #2517 Resolve this issue.

0reactions
nadrooJcommented, May 29, 2020

I agree that any potential vulnerability on a website isn’t your fault, however I would argue that your software incorrectly labelling that website as another because of a character in a query string is.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Parsing query parameters that contains square brackets in ...
Spring boot tries to bind a request parameter named order when you put name not the whole map. You should remove name to...
Read more >
Functions, operators, and conditionals | BigQuery
This function ignores NULL input arrays, but respects the NULL elements in non- NULL input arrays. An error is raised, however, if an...
Read more >
REST API Best Practices for Parameter and Query String Usage
When building RESTful APIs, it's important to remember that the REST protocol is state-based and strongly reliant on HTTP. Parameters.
Read more >
Safari Technology Preview Release Notes - Apple Developer
Fixed an issue where browser.tabs sometimes returned an incorrect URL for pinned tabs. Bug Fixes. Fixed the Share Menu when sharing an image...
Read more >
Groovy Language Documentation
You will notice that the resulting string contains a newline character as ... and surrounded by square brackets, and we assign that list...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found