Autocomplete for overriding methods does not show if the method has non-imported types

Describe the bug

Assume we’ve this on a.dart file:

import 'dart:async';

abstract class Base {
  FutureOr<String> method() => '';
}

And on b.dart file we are trying to overide Base.method:

import 'a.dart';

class BaseImpl extends Base {
  
  // <~~ typing the word `method` here does not show autocomplete suggestions 

} 

i.e.:

Though, if we import dart:async in b.dart, the autocomplete for override works.

The same issue would occur if the non-imported type is an argument of the method instead of a return type.

Expected Behavior:

I would expect the autocomplete to show up, and once it’s selected, it’ll import all the necessary libraries (i.e. dart:async in this case)

---

Please complete the following information:

• VS Code version: Version: 1.70.1
• Dart extension version: v3.46.1
• Dart/Flutter SDK version: Dart SDK version: 2.17.6 (stable) (Tue Jul 12 12:54:37 2022 +0200) on “macos_x64”

[DanTup]

https://github.com/dart-lang/sdk/commit/1d64cba68e32ed9ef6b433287a53a36da446a005 addresses the items not showing up in completion, and https://github.com/dart-lang/sdk/commit/699b42c8e3ecfe96d1247241b3c9a9312e65e8bb adds support for bringing in potentially multiple) imports so the code is valid.

These are SDK changes, so will require a future SDK release to show up. Thanks for raising this and figuring out what was triggering it - it saved me some time debugging! 😃

[DanTup]

• https://dart-review.googlesource.com/c/sdk/+/270180 suppressed the import edits for override completions (causing the completion to appear now, although inserts without imports)
• https://dart-review.googlesource.com/c/sdk/+/270181 adds support for multiple imports during LSP resolution and populates them

Prefixes etc are respected (since they don’t produce additional imports), although we still don’t consider collisions (as noted above, that’s not specific to this).