LSP crashes while editing one specific file on my Flutter project.

Describe the bug After updating to null-safe Flutter, a file named decorations.dart on my file hiearchy shows errors, crashes LSP and does not respond to modifications to the file (errors are still indicated even after modifying/fixing them.). LSP keeps producing error messages after every keystroke and mouse movement.

To Reproduce Steps to reproduce the behavior:

1. Generate a file named decorations.dart. (On my project, file path is as following: lib/values/decorations.dart)
2. Write some code which violates null-safety.
3. Try to modify file.

Expected behavior I expect the editor and LSP to behave same way as when I modify any other file.

Flutter Doctor Log

[√] Flutter (Channel stable, 2.0.2, on Microsoft Windows [Version 10.0.18363.1441], locale tr-TR)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 3.5)
[√] IntelliJ IDEA Community Edition (version 2018.3)
[√] VS Code, 64-bit edition (version 1.54.2)
[√] Connected device (2 available)

---

Note I get a seperate report from LSP for every action performed while modifying the file; here is a few examples:

[Error - 21:22:13] Request textDocument/hover failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:22:13] Request textDocument/codeAction failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:22:14] Request textDocument/documentHighlight failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:22:14] Request textDocument/codeAction failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:22:14] Request textDocument/hover failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:32:58] Request textDocument/hover failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:32:59] Request textDocument/hover failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:32:59] Request textDocument/hover failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart
[Error - 21:32:59] Request textDocument/codeAction failed.
  Message: Invalid file path
  Code: -32003 
...\lib\values\decorations.dart

[DanTup]

I was able to reduce this to a small amount of code in https://github.com/dart-lang/sdk/issues/45504. I think it might be related to having both private and public variables in the same definition:

const kOne = 1, _kTwo = 2;

Renaming _kTwo to just kTwo or putting it in its own declaration seemed to prevent the issue, so that might be a reasonable workaround for you for now until the issue is fixed.

I’ll close this issue as once it’s fixed in the SDK (and you have an updated SDK) there will be nothing to do in the VS Code extension. Thanks!

[DanTup]

Thanks! I can reproduce this - it’s definitely failing to parse something in that code. I’ll try narrow it down and file an SDK issue with a small repro. Thanks!