Many irrelevant suggestions appear, and they may be autoselected by default, when using optional parameters

Here, I created a Flutter stateless widget with the stless snippet, and after typing appBar: the first suggestion is stless and I have to scroll all the way up to see the AppBar() suggestion.

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: ,
    );
  }
}

[DanTup]

Suggestions 2-6 shouldn’t appear unless they’re of type Decoration or return a Decoration.

It’s often valid to type these items, because you could be writing something like:

Container(
  decoration: new MyThing().theDecoration,
)

or

Container(
  decoration: SomeClass.myInstance["thing"],
)

Snippets are also always valid, because their contents could contain anything (for example you could have a snippet of code that returns a decoration).

The completion options actually from from the SDK so any changes would need to be made there (though based on the above, I don’t think the things you want to go away will). They are sorted by a rank, however, so it’s possible that could be tuned if there are items that should be at the top that are appearing down the list.

As a result of this, VSCode selects an irrelevant suggestion by default because of the default value of editor.suggestSelection

Unfortunately VS code has many defaults that result in quirks like this (which is why I’ve started collecting them in the recommended settings page, which we may point users at in the future). The issue isn’t isolated to Dart, TypeScript has exactly the same thing:

If you think the default in VS Code should be changed, you could open an issue in the VS Code repo (I’d certainly 👍 it if you post the link here - it makes me sad that we need to document all the “bad” defaults for reasons like this).

[DanTup]

I’ve added this to the recommended settings page but I don’t think there’s anything more I can do here. Even the TypeScript extension has had the same issue reported, and the fix is to modify the setting. I agree this isn’t great, but I don’t want to override peoples settings.