Cluster keeps appending "interface" flag to job script

When I run the following code snippet:

from dask_jobqueue import SLURMCluster

cluster = SLURMCluster(memory="100GB", cores=40, interface="ib0")

for _ in range(20):
    _ = cluster.job_script()
    
print(cluster.job_script())

I get the following output:

#!/usr/bin/env bash

#SBATCH -J dask-worker
#SBATCH -n 1
#SBATCH --cpus-per-task=40
#SBATCH --mem=94G
#SBATCH -t 00:30:00

/path/to/python -m distributed.cli.dask_worker tcp://xx.xx.xx.xx:pppp --nthreads 5 --nworkers 8 --memory-limit 11.64GiB --name dummy-name --nanny --death-timeout 60 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0 --interface ib0

It seems everytime the job script method is called, the interface flag is appended to it. I am running dask-jobqueue==0.8.0 off the conda-forge channel. (Python 3.10 if relevant)

You can replicate this with PBSCluster as well. The issue seems to be in how worker_extra_args are handled in the __init__() method of dask_jobqueue.core.Job

[guillaumeeb]

Nice catch and many thanks @jolange.

[jolange]

Ok, this is a subtle combination of two things:

1. The one you noted: The config is assigned to worker_extra_args: https://github.com/dask/dask-jobqueue/blob/f79f9136542abd86566e0a36f7370c144052ee9d/dask_jobqueue/core.py#L226-L228
2. In the renaming, I changed from X = X + NEW to X += NEW:

         if interface:
-            extra = extra + ["--interface", interface]
+            worker_extra_args += ["--interface", interface]

This changes the config, whereas before worker_extra_args (or extra then) was newly assigned. I will revert that!