flake8 ignore configuration

I was wondering whether there is a good motivation for the flake8 ignore settings and whether people would be open to use the flake8 defaults instead, or maybe a smaller set of ignores instead.

I am aware this is a bit of a bikeshedding issue, but I think that this is better to discuss this when the project is young than later down the line.

I ran flake8 with the default settings and there are eight flake8 violations which are super easy to fix (if you are curious the winner is E265 block comment should start with '# ' which to me is not very controversial).

I had a quick look and from what I can tell, the flake8 ignore settings of some projects in the dask organization projects are copied from the dask/dask one. I found this was introduced in https://github.com/dask/dask/pull/1464 and it does not look like there is a strong motivated reason behind it. Some projects have drifted a bit off like dask-ml and dask-kubernetes.

[mrocklin]

No strong thoughts from me personally.

I think that style settings should be determined by people who tend to maintain the project. In this case that seems to be you @lesteve (along with others like @jhamman and @jakirkham) so your preferences should probably determine what this project does in regards to style.

Changing style in dask/dask or dask/distributed is also doable but will likely require more discussion. If that is your goal (which seems reasonable for consistency) then I recommend raising an issue on the dask/dask issue tracker.

On Wed, Apr 18, 2018 at 3:49 AM, Loïc Estève [e-mail] wrote:

I was wondering whether there is a good motivation for the flake8 ignore settings and whether people would be open to use the flake8 defaults instead, or maybe a smaller set of ignores instead.

I am aware this is a bit of a bikeshedding issue, but I think that this is better to discuss this when the project is young than later down the line.

I ran flake8 with the default settings and there are eight flake8 violations which are super easy to fix (if you are curious the winner is E265 block comment should start with '# ’ which to me is not very controversial).

I had a quick look and from what I can tell, the flake8 ignore settings of some projects in the dask organization projects are copied from the dask/dask one. I found this was introduced in dask/dask#1464 https://github.com/dask/dask/pull/1464 and it does not look like there is a strong motivated reason behind it. Some projects have drifted a bit off like dask-ml and dask-kubernetes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dask/dask-jobqueue/issues/38, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszH_LZy31VJo3rVQzn0Pe_E0cWdMuks5tpvALgaJpZM4TZlM_ .

[guillaumeeb]

If there is no dask standard config, my point of view is to stick with flake8 default one, adding exceptions only when necessary.