question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Version numbering for next release

See original GitHub issue

Hi All,

As part of an upcoming release I would like to release dask-jobqueue. What should the version number be? Some options:

  1. 0.6.2 - this will be a minor version change in functionality
  2. 1.0 - this library is fairly stable, might as well call it 1.0
  3. 2.2 - let’s just match Dask version numbers going forward

What should we use?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:12 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
lestevecommented, Jul 31, 2019

My preference would be 0.6.2. I feel the pace of development of dask/distributed is a lot quicker than dask-jobqueue and that keeping versions in sync does not make complete sense to me.

I have made some similar comment in https://github.com/dask/dask/issues/5168#issuecomment-516912659.

Something I have been thinking about in seeing the changes needed for distributed >= 2, and now distributed >= 2.2 (thanks a lot for this @mrocklin by the way!) is that dask-jobqueue is exposed to what feels like internal dask/distributed details.

My feeling is that one of the main reason is that at one point we decided to create dask_jobqueue.core.ClusterManager and our base cluster class JobQueueCluster is not inheriting from distributed.cluster.Cluster (see #187 for the PR and #170 for some of the motivations) . I think that we should revisit this decision. I may well be wrong about all the rest of this message because I have not had as much time as I wanted to look at this unfortunately … more than open to comments/complaints/corrections!

It would be great to have @guillaumeeb’s opinion on this because he was the main person involved in this IIRC.

I seem to remember there were two reasons for the dask_jobqueue.core.ClusterManager change:

  • we wanted to do some dask-jobqueue specific experimentations, for example where the scheduler was on a different node than the main script or where the cluster object manages different kind of workers. As we are all quite busy with other things, it did not really happen as far as I know. Also some stuff has happened on the distributed front, e.g. the SpecCluster (although I have not followed very closely it seems like it could do the heterogeneous workers use case).
  • we wanted to have different arguments for scale min_cores, min_memory. I don’t think that was one of the main reason. See #184 for the PR.
0reactions
guillaumeebcommented, Oct 11, 2019

I think we can close this one for now, consensus was reached to keep independant ersion numbering.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Best Practices When Versioning a Release
Five Tips for Implementing Semantic Versioning · 1 - Communicate clearly to your users · 2 - Have an open release schedule (that...
Read more >
Software versioning
The first major release of OS X was given the version number 10.0, but the next major release was not 11.0. Instead, it...
Read more >
Semantic Versioning 2.0.0 | Semantic Versioning
Version 1.0. 0 defines the public API. The way in which the version number is incremented after this release is dependent on this...
Read more >
What rules does software version numbering follow?
Major version numbers change whenever there is some significant change being introduced. · Minor version numbers change when a new, minor feature is...
Read more >
Best Practices When Versioning a Release
If your release schedule releases a new major release every twelve months, do your best to stick to it. Don't have one release...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found