Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

List optional cytoolz dependency

See original GitHub issue

Would be nice if somehow cytoolz was noted as an optional dependency in setup.py. Not totally sure the right place to add it though.

Issue Analytics

State:
Created 6 years ago
Comments:9 (3 by maintainers)

Top GitHub Comments

1reaction

jakirkhamcommented, Oct 29, 2018

FWIW, @dhirschfeld, had attempted this in PR ( https://github.com/dask/dask/pull/3456 ). I don’t plan to carry it forward near term. So feel free to pick that up if you like. Should just be a matter of addressing a few comments in there.

0reactions

mrocklincommented, Oct 25, 2018

If someone wants to compile a list of all optional dependencies that would be welcome.

FWIW I doubt that including cytoolz over toolz will have a significant effect on runtime in most cases.

Most other missing dependencies will inform the user with informative error messages.

On Wed, Oct 24, 2018 at 10:11 PM Dave Hirschfeld notifications@github.com wrote:

This appears to be the approach taken by pandas:

https://github.com/pandas-dev/pandas/blob/master/ci/requirements-optional-conda.txt

…by default install just the minimal deps but list (somewhere) all optional deps, including any version requirements.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask/issues/2812#issuecomment-432889005, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszCEzkVRVLbzN3HU3ojPb3kytPyJtks5uoR3hgaJpZM4QDZHI .