question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

New Dask 2022.10.1. release broke Airlfow's integration tests

See original GitHub issue

The new Dask release broke (due to bokeh removal) tests for Airflow Dask Executor integration. Since we have almost no knowledge of Dask, we have to defer it to your team to fix it.

In the meantime we just limit Dask to < 2022.10.1 in Airlfow: https://github.com/apache/airflow/pull/27383 . I would love if someone from the Dask team or especially Dask users could take a look and fix the tests as appropriate.

Example failing build here: https://github.com/apache/airflow/actions/runs/3356434694/jobs/5561625862#step:9:19064

Fixing it is as easy as getting our breeze env runnnig and updating to latest version of dask there and runnint tests - easy steps explained in https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst - an easy way to become an Airflow contributor.

Also I think Dask team should seriously consider if they want to start maintaining it separately from Airflow. We have virtually no experience of Dask in the maintainer team, and we already started discussions in the past to deprecate the executor regardless (and we might soon come back to the discussion) - I wonder if that is something you would like to take on that one. We have some examples of integrations with Airlfow (for example Great Expectations) where they maintain Airlfow integration in their own packages (precisely for the reason of maintaining future compatibility and keeping up with their deprecations/changes).

Describe the issue:

Minimal Complete Verifiable Example:

# Put your MCVE code here

Anything else we need to know?:

Environment:

  • Dask version:
  • Python version:
  • Operating System:
  • Install method (conda, pip, source):

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
mrocklincommented, Oct 31, 2022

Thank you for reporting @potiuk . We’ll take a look shortly.

@ian-r-rose can I ask you or someone on your team to investigate what happened? My guess is that some bokeh import was made non-optional in the latest release.

0reactions
mrocklincommented, Oct 31, 2022

This has been resolved upstream in Dask. My apologies for the issue. The previous release has been yanked from PyPI and a new release has been published. It is on PyPI now and should be on conda-forge shortly.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Release Notes — Airflow Documentation
New to this release of Airflow is the concept of Datasets to Airflow, and with it a new way of scheduling dags: data-aware...
Read more >
Changelog — Dask.distributed 2022.12.1 documentation
This release changes the default scheduling mode to use queuing. ... Consolidate broken comm testing utilities (GH#5654) James Bourbeau.
Read more >
Integration tests in ASP.NET Core | Microsoft Learn
Learn how integration tests ensure that an app's components function correctly at the infrastructure level, including the database, ...
Read more >
Integration tests broken after migrating to ASP.NET Core RC2
On RC2, TestServer.CreateBuilder() was removed. Therefore, I tried to create a new TestServer using the following code: var server = new ...
Read more >
Integrated Tests Are A Scam - The Code Whisperer
Integrated tests won't kill you, although the scam remains a problem. ... you use in the broken code path now work correctly together....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found