Raise exception if the user passes in unused keywords to Client

For example

client = Client(address, dashboard_address="foo")

The dashboard address keyword is useful if we’re creating a LocalCluster, but it doesn’t get used if we’re connecting to an already-started scheduler. In these cases, we should probably raise, otherwise we risk adding confusion.

cc @shwina

[mrocklin]

Most of the time we tend to use built-in exceptions, but with informative messages. We should probably either change this policy everywhere (and make dozens of new exception types) or keep it. I’m in favor of keeping it.

The code you provide would solve the specific issue around dashboard_address, but we would prefer a solution that covers any excess keyword. dashboard_address was just used above as an example.

[mrocklin]

I don’t think that we use them anywhere else, but hopefully if we do then tests will start failing if this is wrong.

On Fri, Oct 4, 2019 at 8:47 AM Jonathan De Troye [e-mail] wrote:

Yeah, simpler is better. I didn’t know if that would be too broad and raise for other extra keywords that are not in LocalCluster.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dask/distributed/issues/3014?email_source=notifications&email_token=AACKZTGZ563LINOTTWW47X3QM5CPHA5CNFSM4ISD3XK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEALWKUQ#issuecomment-538404178, or mute the thread https://github.com/notifications/unsubscribe-auth/AACKZTCW7VDRCMUXNJPQH2LQM5CPHANCNFSM4ISD3XKQ .