Add support for orderBy in multiple tables

orderBy as written compares every orderBy against every table in the expected data set. If the orderBy column doesn’t exist in one of the provided tables it will NPE.

For example:

# expected.yml
foo:
  - id: 1
  - id: 2
bar:
   - uuid: "uuid'3e6a4f38-f9b3-4697-bf9c-f9e957af2fdb'"

@ExpectedDataSet(value = "expected.yml", orderBy = "id")

The implementation of orderBy is critically flawed. Which tables should orderBy apply to? Should users be forced to supply one file per table and each array index mapped to an orderBy index? In that case, how would you handle ordering multiple columns for multiple tables?

DbUnit had DatabaseAssertionMode.NON_STRICT_UNORDERED which worked exactly as expected: it compares records without respect to ordering. Can’t we please just have that? 😭

[jenskreidler]

Maybe it makes sense to apply the specified “orderBy” column-list top down in the expected dataset, depending  upon occurrence/existence: Example: orderBy={“id”, “uuid”} in expected-fo.yml: table1:- id: 1   name: “Foo1” table2:- uuid: “fdfsd-fdfsd-fdfds”   name: “Foo2” table3:- id: 3  uuid: “abc-def-ghj”  name: “Foo3”

shouldn’t throw any exception but:- sort table1 by “id”- sort table2 by “uuid”- sort table3 by “id”, then “uuid”

Am Freitag, 23. August 2019, 13:50:50 MESZ hat Rafael M. Pestano <[e-mail]> Folgendes geschrieben:  

I agree that would be better if we could specify table and column in order by I’m just not sure if there is a simple way to do that without polluting/making the API harder to use

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[rmpestano]

Fixed according to @jenskreidler comment.