DBUnitInterceptorImpl seems to be relying on junit4 being transitively provided by dbunit

Hi @rmpestano thanks again for the great tool! I’m trying to workaround the https://sourceforge.net/p/dbunit/bugs/437/ (basically building a custom version of rider-cdi using custom version of dbunit) and i’ve noticed, that in the master of dbunit JUnit 4 is marked optional in pom.xml. Does it make sense from your point of view to rely on JUnit 4 being provided for rider-cdi by dbunit? It’s not given, that each project using rider-cdi is also using JUnit 4, in fact we’re using JUnit 5 in our project 😉 Would it be better to maybe remove https://github.com/database-rider/database-rider/blob/1c2ba2aaa9ee1b4cc1f1ba101c619c480052ee7b/rider-cdi/src/main/java/com/github/database/rider/cdi/DBUnitInterceptorImpl.java#L41-44 from DBUnitInterceptorImpl and maybe provide this functionality in a separate @Interceptor with a higher @Priority? Possibly related: #207 to make it consistent with JUnit 5

[coiouhkc]

Perfect! Thanks for handling it so quickly.

[rmpestano]

Thanks for the feedback.

For now, I don’t think we need to make it configurable mainly because it’s cdi module specific config and I don’t think it would be nice to have it in global config.

Also, creating an annotation only for that would add a bit of complexity we may not need.

Let’s start with this constant set of annotations which I think will cover most of the cases and then if users have issues we can think of something else.

Sounds good?