Can't generate dbt docs

Describe the bug

We use the dbt-databricks adapter and can successfully read our models from dbt and also write them. However, when we call dbt docs generate we get the following error: Expected only one database in get_catalog, found.

To be on the safe side, I took another look at the source.yml. Unfortunately, only the schema is set there and I don’t know why dbt docs generate shouldn’t work.

Steps To Reproduce

Try to generate the dbt docs for a databricks destination / source

Expected behavior

Docs should be generated

Screenshots and log output

System information

The output of dbt --version:

╰─$ dbt --version    
installed version: 1.0.1
   latest version: 1.0.1

Up to date!

Plugins:
  - databricks: 1.0.0
  - spark: 1.0.0

The operating system you’re using:

The output of python --version:

╰─$ python --version              
Python 3.8.12

[jtcohen6]

Thanks for this @mcfuhrt! I was able to reproduce the error, using the example you’ve provided.

It looks like this line in your source definition is to blame:

    quoting:
      database: true

If I switch that to database: false, or remove that line entirely, docs generate works fine.

Alternatively, if I add those lines to dbt_project.yml so that the project-wide quoting config matches (docs), it also works.

There are two ways forward I can see:

1. Fix the logic within SchemaSearchMap (called by _get_catalog_schemas), which currently views a quoted "None" database and an unquoted None database as distinct entries in the set of databases. This makes sense in the general case—they have different quote_policy—but it doesn’t make sense when the value is None.
2. Defining this config doesn’t (shouldn’t) have any actual effect. Given that we don’t allow database to be defined elsewhere in dbt-spark (+ dbt-databricks, at least until https://github.com/dbt-labs/dbt-spark/issues/281), it really feels like our answer here should be to raise an explicit error any time the quoting config is defined at the database level. That could look like adding a __post_init__ hook to the SparkQuotePolicy:

    def __post_init__(self):
        if self.database:
            raise RuntimeException('Cannot set database-level quoting!')

[github-actions[bot]]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.