ADO.NET traces missing after upgrade from 1.7 -> 1.10
See original GitHub issueDescribe the bug
After upgrading from Trace Agent 1.7 to 1.10(removing the Datadog.Trace.ClrProfiler.Managed
package in the process), we’ve stopped receiving Trace data for postgres/npgsql(via Dapper). Sql Server traces are still coming through for other full framework applications on the same server. Debug logging shows the below, but never shows the “Replaced calls” message that we’d expect for the instrumented method:
[w3wp.exe] 6288: [debug] JITCompilationStarted: function_id=140705392839240 token=100668737 name=System.Data.Common.DbCommand.System.Data.IDbCommand.ExecuteReader()
By comparison, 1.7 shows the following:
[w3wp.exe] 3372: [info] *** JITCompilationStarted() replaced calls from System.Data.Common.DbCommand.System.Data.IDbCommand.ExecuteReader() to System.Data.Common.DbCommand.ExecuteDbDataReader() 100668732 with calls to Datadog.Trace.ClrProfiler.Integrations.AdoNetIntegration.ExecuteDbDataReader() 167773671
[w3wp.exe] 3372: [info] *** JITCompilationStarted() replaced calls from System.Data.Common.DbCommand.ExecuteReaderAsync() to System.Data.Common.DbCommand.ExecuteDbDataReaderAsync() 100668744 with calls to Datadog.Trace.ClrProfiler.Integrations.AdoNetIntegration.ExecuteDbDataReaderAsync() 167773672
Expected behavior Npgsql calls via Dapper are instrumented.
Runtime environment (please complete the following information):
- Instrumentation mode: Have tried both automatic and with the NuGet package
- Tracer version: 1.10.0
- OS: Windows Server 2012 R2
- CLR: .NET Core 2.2
Additional context
- Dapper 1.60.6, Npgsql 4.1.1(Also tried 4.1.2)
- See also: https://github.com/DataDog/dd-trace-dotnet/issues/540
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:12 (6 by maintainers)
Top GitHub Comments
@bretkoppel @gshackles @fehmianac @NickAdolf @AndreyMarchuk We have produced a Pre-Release version 1.13.3-prerelease that addresses
postgres
instrumentation throughDapper
. Would you be willing to download it and try it out? cc: @lucaspimentel@bretkoppel: We released version 1.14.0 which includes the changes you tested in prerelease version above. We can now move on to #661!