Dapper Calls via Execute Aren't Instrumented
See original GitHub issueDescribe the bug
Database calls using the Dapper library’s .Execute...
method seem to delegate to IDbCommand.ExecuteNonQuery()
, but they don’t appear when traced. Calls via .Query...
are instrumented. This happens against both Sql Server and Postgres(using npgsql).
To Reproduce Super basic example gist is here. You’ll need to do some connection string swapping but hopefully this is clear enough.
Expected behavior
4 spans are created(2 for .Execute
; 2 for .Query
)
Screenshots https://cl.ly/592416576d1c
Runtime environment (please complete the following information):
- Instrumentation mode: Automatic
- Tracer version: 1.13.3
- OS: Windows Server 2012 R2
- CLR: .NET Core 2.2
Additional context This is a follow-up to https://github.com/DataDog/dd-trace-dotnet/issues/581 and https://github.com/DataDog/dd-trace-dotnet/issues/540
@bobuva Pinging you as you asked! Please let me know if I can add anything.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:8 (4 by maintainers)
Top GitHub Comments
@lucaspimentel Apologies for the delay - I finally had a chance to try out 1.19.0 and we are seeing these missing spans. Thank you! Feel free to close this out.
These log messages will be very useful, @bretkoppel. Thanks!