question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Netty 4.0 integration doesn't seem to work

See original GitHub issue

Summary

I’ve followed https://docs.datadoghq.com/tracing/setup/java/, but the Netty 4.0 Client instrumentation doesn’t seem to work with Play 2.5 or even just AHC 2.0 by itself.

Expected result

I expect x-datadog-trace-id, x-datadog-parent-id headers attached to the outbound HTTP request, and a child span named netty.client.request.

I get neither.

Repro

I’ve replicated Netty40ClientTest in a new project: https://github.com/htmldoug/datadog-netty4-failing.

You can repro with sbt run.

Screenshots

no child span

wireshark

Relates to #352. cc: @tylerbenson @realark

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
htmldougcommented, Aug 8, 2018

I’ve logged that as a new issue, https://github.com/DataDog/dd-trace-java/issues/432. I think it’s more of a play-integration issue than a netty issue. I’m pretty satisfied with the netty part. Thanks!

1reaction
tylerbensoncommented, Jul 30, 2018

It was funny, your report came in right as we were investigating it ourselves. We were trying to figure out why the netty instrumentation wasn’t working with Spring Webflux. So we already had a few hours head start . 😉

@htmldoug you can try the jar built by CI: https://7229-89221572-gh.circle-artifacts.com/0/home/circleci/dd-trace-java/libs/dd-java-agent-0.12.0-SNAPSHOT.jar For PR’s, we save it as artifacts on the CI, but when it gets merged to master, there will be a snapshot published to the snapshot repo.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Netty 4.0 Client/Server Freezes on Connection - Stack Overflow
When the migration is complete, you will access your Teams at stackoverflowteams.com, and they will no longer appear in the left sidebar on ......
Read more >
Requirements for 4.x - Netty.docs
The JDK implementation by Netty only supports either ALPN or NPN at any given time and NPN is only supported in JDK 7....
Read more >
netty/netty - Gitter
I send data to user with Channel.writeAndFlush and immediately call Channel.close.await, however if the data is huge, the user doesn't get the full...
Read more >
Reactor Netty Reference Guide
As mentioned earlier, the easiest way to use Reactor Netty in your ... When TCP server metrics are needed for an integration with...
Read more >
Netty direct buffer detection broken due to missing module ...
INFO [io.netty.util.internal.PlatformDependent] Your platform does not provide complete low-level API for accessing direct buffers reliably.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found