Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

parseISO with Date argument typings

See original GitHub issue

I have input coming from the server as Date object but in a certain case, the server input is replaced by a JSON file with the same data. But since this is JSON, Date’s are now strings.

parseISO still appears to work with Date as argument but the typings say the argument can only be string.

Is this just a missing type?

Issue Analytics

State:
Created 4 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

Christilutcommented, Jan 8, 2020

Ah that’s really good to know. Seems like better standard behavior than new Date too.

0reactions

kossnocorpcommented, Jan 8, 2020

Yeah, but also new Date parsing algo differs from a browser to browser, so we were getting many cross-browser bug reports from people parsing loose formats (e.g. Jan 14).

Another case to use parseISO is when you have an incomplete string. new Date('2019-01-01') will parse the date in UTC unlike parseISO that would return the date in the local timezone:

new Date('2019-01-01')
//=> Tue Jan 01 2019 04:00:00 GMT+0400 (Samara Standard Time)

new Date(2019, 0, 1)
//=> Tue Jan 01 2019 00:00:00 GMT+0400 (Samara Standard Time)

parseISO('2019-01-01')
//=> Tue Jan 01 2019 00:00:00 GMT+0400 (Samara Standard Time)