Problem with documentation for isSameYear function

There is an issue with the documentation for isSameYear function

The documentation does not show the third parameter for options, there for this returns false because the week does not starts on monday

The problem

💻 Code demonstrating the problem

import isSameYear from 'date-fns/isSameYear'

const start = new Date("2021-12-28") // a monday
const end = new Date("2022-01-02") // a sunday

🙁 Actual behavior

console.log(_.isSameWeek(start, end))
false

🙂 Expected behavior

console.log(_.isSameWeek(start, end), { weekStartsOn: 1 })
true

[fturmel]

@bjornwiberg I think you made a simple mistake here, Dec 28 2021 was a Tuesday and not a Monday. (EDIT: that wasn’t particularly relevant to the issue though, adding more details).

import { isSameWeek } from "date-fns";

const start = new Date(2021, 11, 27); // a Monday
const end = new Date(2022, 0, 2); // a Sunday

console.log(isSameWeek(start, end, { weekStartsOn: 1 })); // week starts on Monday
// true

console.log(isSameWeek(start, end)); // week starts on Sunday by default
// false

[bjornwiberg]

yes i think thats the case