question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Find Drones button not disabled correctly

See original GitHub issue

Thank you for your help ❤️

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new non-profit foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Missions

The DAV project you are looking at is Missions. Missions is the client facing side of the marketplace connecting DAV users looking to ship packages, with autonomous vehicles such as drones.

How you can help

The Issue

We recently added the ability to set pickup and dropoff locations using actual addresses (and not coordinates as we usually had).

If the user doesn’t select any address the Find Drones button becomes disabled. Only when both pickup and dropoff addresses have been selected will it become active.

However if the user selects an address both for the pickup and dropoff making the button enabled and then removed the selection at one or both of those - the button remains active - leading to an incorrect application state.

If the address selector of either pickup or dropoff is cleared the state of the button should be updated correctly to disabled mode.

A good starting point would be to look at the code changes done for Issue #92

Contributing to Missions

  • Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
  • Comment in this issue that you would like to do it.
  • Open the Missions GitHub page and click the ★ Star and then ⑂ Fork buttons.
  • Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/missions.git
  • Make changes in the LICENSE file
  • Once you’ve made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
  • Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missions) and create a pull request for your changes.
  • Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #5)
  • Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
ghostcommented, Mar 6, 2018

Actually, @TiagoLisboa, it is not solved. I erased those lines in a subsequent commit to make the code smaller. So you can still do that issue following the referenced I gave and resolving the conflicts with the master. Note that now, the Link component is disabled. In the reference, it renders when the condition is met

2reactions
ghostcommented, Mar 6, 2018

@srfrnk i think i resolved this in PR #105 when created this.state.disableSearchPickup and thia.state.disableSearchDropoff but i will let @TiagoLisboa to solve this one 😄

Read more comments on GitHub >

github_iconTop Results From Across the Web

Drone Won't Connect To The Controller (7 Ways To Fix It)
Start off by switching on the drone using its power button. Hold on to the button until you hear a beeping sound or...
Read more >
Troubleshooting for DJI Drones - DroneDeploy
Tips and tricks for flying with the DroneDeploy mobile app. Below is a guide to troubleshooting common problems with the DroneDeploy...
Read more >
Quadcopter Won't Arm | CLEANFLIGHT BETAFLIGHT - YouTube
Please consider supporting me on Patreon: https://www.patreon.com/thedroneracingengineerIf your Cleanflight or Betaflight quadcopter won't ...
Read more >
How to Unlock Geofencing on Your DJI Drone
Start by using DJI's Fly Safe Geo Map to see whether the area in which you want to fly is located in a...
Read more >
Quadcopter Doesn't Arm? Let's Fix it! - Oscar Liang
This tutorial shows you how to troubleshoot and fix a quadcopter that doesn't arm. I will also explain the common problems that prevent...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found