question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

I’ve been refining this project a lot for my own use and would like to share it with you, but I suggest it should be an upgraded major version, since I let myself break some API to have better organization and understanding of this library. Plus because a lot is rewritten, It will be probably better to handle it on a different branch and an alpha version on npm (1.0.0-alpha.1).

Stuff added:

  • videoIds: option to load an array of playable video IDs
  • playlistId: option to load a YouTube playlist’s ID
  • previousVideo() / nextVideo(): methods for multiple videos
  • playVideoAt(index): play the video of index place in videoIds or playlistId
  • videoIndex(): a promise method to get the index of the currently played video out of multiple videos
  • Smooth linking with react-native link and rnpm link for both platforms. No other installation steps.
  • Updated README with less ambiguity about props (Differences between iOS and Android) and also explanations of known issues I have discovered while working.
  • Native code refactored and build warnings omitted
  • Started tracking and pinning peerDependency of RN

iOS Improvements

  • Instead of reloading for every prop change, the inner WebView holding the YouTube iFrame now loads once and is updated via methods
  • Native code refactored to use newer events passing, former is being deprecated
  • Updated files from youtube-ios-player-helper to 0.1.6

Android improvements

  • Refactored layouting of the YouTubePlayerFragment instances to prevent fatal error when multiple instances override each other if succeed each other in RN #64

Upgraded example project I’ve totally rewritten the example project to showcase all the added functionality, plus it was upgraded to RN 0.37. Also the example project is now linked to the working directory of the library so it can be used as a developing project, with a simple npm install command to update the underlying code.

The repository can be found here.

Lets open a v1 branch and start publishing this to npm

Thanks

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:7
  • Comments:28 (17 by maintainers)

github_iconTop GitHub Comments

2reactions
davidohayon669commented, Feb 18, 2017

@jujumoz any plan on incorporating this as a next version branch?

Other than tons of refactoring, I think the work I did here on playlists, updated example / development app, and simplified installation is extremely valuable to the freshness of this project.

2reactions
davidohayon669commented, Jan 29, 2017

@vesper8 I would gladly take a maintainer role in this repository. I think it can be maintained much better than just be patched with pull-request everytime. All depends on the owners @julien-inprogress

Read more comments on GitHub >

github_iconTop Results From Across the Web

V1 Sports - Golf & Baseball Video Analysis, Ground Pressure ...
V1 Sports builds golf and baseball software and apps that allows athletes and coaches to video and analyze athletic movement, ground pressure, and...
Read more >
V-1 flying bomb - Wikipedia
The V-1 was the first of the Vergeltungswaffen (V-weapons) deployed for the terror bombing of London. It was developed at Peenemünde Army Research...
Read more >
V1 | SKYbrary Aviation Safety
Action Speed Decision Speed Critical Engine Failure Recognition Speed Definition V1 is the maximum speed at which a rejected takeoff can be initiated...
Read more >
V-1 missile | military technology - Encyclopedia Britannica
It was launched from catapult ramps or sometimes from aircraft. It carried an 850-kilogram (1,870-pound) explosive warhead at about 580 km (360 miles)...
Read more >
V1 Radar Detectors - Valentine One
The All-New Valentine V1 Gen2 Radar Detector offers full coverage against both radar and laser and is designed for absolute range superiority.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found