Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Read-only menu items

See original GitHub issue

It would be great if we could add a read-only menu item, for example to show a status, version number, or other static info. A read-only menu item should not be selectable and it should not close the menu when the user clicks or presses enter on it.

The existing readOnly prop might be used for this functionality. The disabled prop could work too, but it doesn’t cover the purpose as nicely. Currently, these props simply get passed on to the rendered span, where they don’t have any effect on the behavior of the menu item.

Issue Analytics

State:
Created 3 years ago
Comments:7

Top GitHub Comments

1reaction

shirshendubhowmickcommented, Aug 8, 2020

I agree there should be a disabled option natively supported by the library. However can’t promise a specific date when we will be able to implement that. Currently there are lot a of things going on to improve in the library related to the legacy code.

I have added this feature to the product roadmap https://github.com/davidtheclark/react-aria-menubutton/projects/1

Hopefully will be implemented in sometime.

0reactions

speecommented, Aug 7, 2020

Thanks for your replies and sample, @shirshendubhowmick. I understand I could check if a selected item should be handled, but my idea about supporting read-only items would be that the library checks this before calling the selection handler in the first place. It would also eliminate these items from the focus cycle.

In fact, as #67 shows, including an element other than a MenuItem results in this exact behavior.