Programmable API createDatabase arguments are overridden

I’m submitting a…

• Bug report
• Feature request
• Question

Current behavior

Command line parameters override createDatabase parameters in Programable API.

$ DATABASE_URL=postgres://localhost/postgres node index.js
[INFO] Created database "expected"
$ DATABASE_URL=postgres://localhost/postgres node index.js unexpected
[INFO] Created database "unexpected"

Expected behavior

I would expect parameters provided to createDatabase always override possible command line arguments.

$ DATABASE_URL=postgres://localhost/postgres node index.js
[INFO] Created database "expected"
$ DATABASE_URL=postgres://localhost/postgres node index.js unexpected
[INFO] Created database "expected"

Minimal reproduction of the problem with instructions

$ cat index.js
var dbmigrate = require('db-migrate');
var dbm = dbmigrate.getInstance(true);
dbm.createDatabase('expected')
.then(function() {
  process.exit(0);
});

What is the motivation / use case for changing the behavior?

Using createDatabase through Programable API in an program that has command line args is not possible at the moment.

Environment

db-migrate version: 0.11.1
db-migrate-pg version: 0.4.0

Additional information:
- Node version: v10.6.0
- Platform:  Mac

<bountysource-plugin>

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

[trubachev]

Faced this bug right now. Found the exact line where it happening https://github.com/db-migrate/node-db-migrate/blob/3c4bd779dead6075509fbc155566b36dc08e94a5/lib/commands/db.js#L10

[wzrdtales]

I will check this, probably conflicting with the general config hirarchy.