KeyError in thread completion_refresh

Description

I get this error occasionally here and there. I ^C and things work again.

Exception in thread completion_refresh:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/local/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/local/lib/python2.7/site-packages/pgcli/completion_refresher.py", line 65, in _bg_refresh
    refresher(completer, executor)
  File "/usr/local/lib/python2.7/site-packages/pgcli/completion_refresher.py", line 105, in refresh_tables
    completer.extend_columns(executor.table_columns(), kind='tables')
  File "/usr/local/lib/python2.7/site-packages/pgcli/pgcompleter.py", line 158, in extend_columns
    metadata[schema][relname][colname] = column
KeyError: u'_stmp_3fc53b90_a'

Your environment

• Please provide your OS and version information. I see it on ubuntu test server and os x machine when connecting to different databases so I think this is irrelevant
• pgcli -v Version: 1.3.1
• pip freeze https://gist.github.com/tejasmanohar/ba53787fa736c95e6e867833e08db804

[j-bennet]

This version of pgcli (1.10.3) is very old. Issue was fixed in 3.0.0, in https://github.com/dbcli/pgcli/pull/1145. Latest released pgcli version is 3.1.0, I’d recommend updating to that.

[kennethkalmer]

I just encountered a very similar issue after adding foreign keys to a partitioned table. Without the foreign keys partitioned tables work like a charm in pgcli. Turns out it can be reproduced quite easily:

$ createdb dev
$ pgcli dev
Server: PostgreSQL 11.3
Version: 2.1.1
Chat: https://gitter.im/dbcli/pgcli
Mail: https://groups.google.com/forum/#!forum/pgcli
Home: http://pgcli.com
kenneth@/tmp:dev> create table cities (id serial primary key not null, "name" text);
CREATE TABLE
Time: 0.009s
kenneth@/tmp:dev> CREATE TABLE measurement (
     city_id         bigint references cities (id),
     logdate         date not null,
     peaktemp        int,
     unitsales       int
 ) PARTITION BY RANGE (logdate);
CREATE TABLE
Time: 0.006s
kenneth@/tmp:dev> Exception in thread completion_refresh:
Traceback (most recent call last):
  File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/threading.py", line 917, in _bootstrap_inner
    self.run()
  File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/threading.py", line 865, in runompletions...
    self._target(*self._args, **self._kwargs)
  File "/usr/local/Cellar/pgcli/2.1.1/libexec/lib/python3.7/site-packages/pgcli/completion_refresher.py", line 65, in _bg_refresh
    refresher(completer, executor)
  File "/usr/local/Cellar/pgcli/2.1.1/libexec/lib/python3.7/site-packages/pgcli/completion_refresher.py", line 110, in refresh_tables
    completer.extend_foreignkeys(executor.foreignkeys())
  File "/usr/local/Cellar/pgcli/2.1.1/libexec/lib/python3.7/site-packages/pgcli/pgcompleter.py", line 278, in extend_foreignkeys
    childcolmeta = meta[childschema][childtable][childcol]
KeyError: 'measurement'

kenneth@/tmp:dev> \d measurement;
+-----------+---------+-------------+
| Column    | Type    | Modifiers   |
|-----------+---------+-------------|
| city_id   | bigint  |             |
| logdate   | date    |  not null   |
| peaktemp  | integer |             |
| unitsales | integer |             |
+-----------+---------+-------------+
Partition key: RANGE (logdate)

Time: 0.024s

Note the output doesn’t show the foreign key, where psql displays it:

$ ~ psql dev
psql (11.3)
Type "help" for help.

dev=# \d measurement
              Table "public.measurement"
  Column   |  Type   | Collation | Nullable | Default
-----------+---------+-----------+----------+---------
 city_id   | bigint  |           |          |
 logdate   | date    |           | not null |
 peaktemp  | integer |           |          |
 unitsales | integer |           |          |
Partition key: RANGE (logdate)
Foreign-key constraints:
    "measurement_city_id_fkey" FOREIGN KEY (city_id) REFERENCES cities(id)
Number of partitions: 0