Upgrade to 0.17.0 crashes app on Android
See original GitHub issueDescription
After upgrading to 0.17.0 from 0.16.0, I’m getting these crashes as soon as a text ticker is rendered (as you can see after, it’s before it even ticks as we use methods to start and stop the animation):
Usage
// @flow
import * as React from 'react';
import { Easing } from 'react-native';
import TextTicker from 'react-native-text-ticker';
import styled from 'styled-components/native';
import { colors } from 'config/theme';
// -----------------------------------------------------------------------------
type Props = {
data: string[],
isPlaying: boolean,
onPressHashtag: (hashtag: string) => boolean | void,
uuid: string
};
type State = {
loopDuration: number // ms
};
// -----------------------------------------------------------------------------
class ScrollingHashtags extends React.Component<Props, State> {
textTicker = TextTicker;
state = {
loopDuration: 0
};
componentDidMount() {
this.getLoopDuration();
}
componentDidUpdate(prevProps: Props) {
const { data: prevData, isPlaying: prevIsPlaying } = prevProps;
const { data, isPlaying } = this.props;
if (prevData !== data) this.getLoopDuration();
if (prevIsPlaying !== isPlaying) {
if (isPlaying) this.textTicker.startAnimation();
else this.textTicker.stopAnimation();
}
}
// Multiply the hashtags strings length by 200ms
getLoopDuration = () => {
// +2 is for # and space chars
const stringLength: number = this.props.data.reduce((a, v) => a + v.length + 2, 0);
this.setState({ loopDuration: stringLength * 200 });
};
onPressHashtag = (hashtag: string) => this.props.onPressHashtag(hashtag);
renderHashtag = (hashtag: string) => (
<Hashtag key={`${this.props.uuid}_${hashtag}`} onPress={() => this.onPressHashtag(hashtag)}>
#{hashtag}{' '}
</Hashtag>
);
render() {
const textTickerProps = {
bounce: false,
duration: this.state.loopDuration,
easing: Easing.linear,
marqueeOnMount: false, // disable auto start
ref: (c: any) => {
this.textTicker = c;
},
repeatSpacer: 0,
scroll: false // prevent the user from grabbing and scrolling
};
return (
<Container>
<TextTicker {...textTickerProps}>{this.props.data.map(this.renderHashtag)}</TextTicker>
</Container>
);
}
}
// -----------------------------------------------------------------------------
export default ScrollingHashtags;
// -----------------------------------------------------------------------------
const Container = styled.View`
flex-grow: 0;
flex-shrink: 1;
margin-bottom: 4px;
margin-right: 5px;
`;
const Hashtag = styled.Text`
color: ${colors.primary};
font-size: 16px;
font-weight: 500;
`;
Environment
React Native Environment Info:
System:
OS: macOS 10.14.5
CPU: (4) x64 Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz
Memory: 610.24 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 12.4.0 - /usr/local/bin/node
Yarn: 1.16.0 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 23.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 27.0.0, 27.0.3, 28.0.2, 28.0.3
System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-25 | Google APIs Intel x86 Atom_64, android-26 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.2 AI-181.5540.7.32.5014246
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.59.9 => 0.59.9
npmGlobalPackages:
create-react-native-app: 2.0.2
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
Issue Analytics
- State:
- Created 4 years ago
- Comments:11 (5 by maintainers)
Top Results From Across the Web
Crash Fix | PUBG Mobile 0.17.0 | Play on Rooted Android ...
Crash Fix | PUBG Mobile 0.17.0 | Play on Rooted Android Devices (2020 Tutorial)#pubgmobilecrashfix #pubgmobileroot #rootpubgmobileAs an ...
Read more >PUBG lag and game crash after new update 0.17.0 . how to fix ...
my device is OnePlus 7 , after the new update (0.17.0) in pubg the game is not performing well as compared to before,...
Read more >Upgrade to 0.59 React native problem when dont have ...
As you can see here and above, there are several improvements to fix the crash on some devices (especially Samsung Galaxy S7).
Read more >cloud_firestore 1.0.0-1.0.nullsafety.0 | Flutter Package - Pub.dev
DEPRECATED: Calling Firestore(app: app) is now deprecated. ... 0.12.9+3 #. Updated error handling on Android for transactions to prevent crashes.
Read more >Unity 2019.x IL2CPP crash on Android 8 | Page 3
It seems to be an issue with google backup data being restored when re-installing a fresh version of the app, and that data...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
This issue should now be resolved with #37. Merged and released in version 0.18.0
@Fouppy @ammarRajabA Can you try this PR and see if it fixes your problem? Going to test myself too but keen to hear your input.
https://github.com/deanhet/react-native-text-ticker/pull/37