question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Thoughts on locking version of "ms" dependency?

See original GitHub issue

Hello 👋 I wanted to open this issue to get a gauge on the single dependency the module has.

Currently this module as a dependency on ms with the semver range set to ^2.1.1.

This in itself is not bad. I know bumping dependency versions is annoying, as well.

I just wanted to check on if there would be strong disinterest in setting it to, like 2.1.1. The reason I’m even bothering to ask is because I love this module, and love using it. When I look at the modules in use, I look at the list of users who can affect the final install. When another package (package_a) takes a dependency on debug, even if it pins the version of debug it depends on (thus none of the debug publishers can affect package_a), all the current and future publishers of ms can still alter the final install of package_a, which means users of package_a must trust the author(s) of ms.

The ms module does not seem to change regularly, so that why I’m even bothering to propose this to get a gauge on the opinions here.

If it’s agreeable, I can make a pull request with the change, even. I’d love to see it backported to the 3.x series (as it seems there have been backports according to npm info debug time), but if 3.x is dead now, then even just 4.x is cool.

Let me know what you think, and if you’re “no” you won’t hurt my feelings 😃

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:1
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
dougwilsoncommented, Mar 26, 2020

I know this is old, but just wanted to follow up here to note that as of today, there are 57 npm users who can publish a new version of the ms package, which feels excessive, but that is just an opinion:

$ npm owner ls ms | wc -l
      57
1reaction
Qix-commented, Feb 22, 2019

The author of ms is @rauchg, whom I trust very, very much, but thank you for the concern - I see this as a non-issue in this particular case.

Read more comments on GitHub >

github_iconTop Results From Across the Web

[rush] Add support for locking versions of dependencies at ...
When working in a high-traffic RUSH monorepo, adding a new project that contains references to other projects (or adding references to other ...
Read more >
Transaction locking and row versioning guide - SQL Server
Each transaction requests locks of different types on the resources, such as rows, pages, or tables, on which the transaction is dependent.
Read more >
Locking dependency versions - Gradle User Manual
Teams that want to always use the latest of their dependencies can use dynamic versions, locking their dependencies only for releases. The release...
Read more >
Nuget: ranges vs. specific versions in packages.lock.json ...
I have a dotnet project with a packages.lock.json committed into my repository for Nuget. The committed version has a dependency property, ...
Read more >
c# - Avoid framework lock-in with dependency inversion
The way this sort of problem is solved is via recompilation. You compile the code under the framework you need, and if you...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found