Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Clarification on signer methods and return types

See original GitHub issue

signer params are very confusing at the moment.

ES256K signers are expected to produce ECDSASignature objects while Ed25519 signers are expected to produce strings.

The developer is notified of this by an error. See SignerAlgorithm.ts#L28 and SignerAlgorithm.ts#L41

This should be improved. Signers should only produce strings since that way, signing can be externalized and there would no longer be a need to understand all algorithms locally, thus allowing support for many more crypto suites.

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

oedcommented, Apr 9, 2020

That sounds great 😃 FYI, we are likely to start using the jose library to do IPLD object signatures and encryption in Ceramic. But afaik, it should still be possible to verify signatures generated from that with the did-jwt library!

0reactions

uport-automation-botcommented, Feb 10, 2021

🎉 This issue has been resolved in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Top Results From Across the Web

Why does Signer use a promise for the address? #263 - GitHub

It has a getAddress method, that returns a Promise and all the classes ... When I import type of Signer from Ethers, it...

Notary Basics: Determining A Signer's Awareness | NNA

Seek Clarification: If you are unsure if a signer understands your questions, you can ask them to tell you the title of the...

Signing and Verifying Ethereum Signatures - Yos Riady

Accounts can use their private key to sign a piece of data, returning a signature of that data. Anyone can verify the generated...

CfnSigningProfile — AWS Cloud Development Kit 2.50.0 ...

A CloudFormation AWS::Signer::SigningProfile . Creates a signing profile. A signing profile is a code signing template that can be used to carry out...

Signing and Verifying Messages in Ethereum

The sign method calculates an Ethereum specific signature with: ... function recoverSigner(bytes32 message, bytes sig) internal pure returns ...